Convert common irsend to specific vendor

[beckmx]

Hello I just bought a new ac unit and until now I realize it has it’s technical difficulties , it’s a whirlpool unit and according to my reading in the repo I need to toggle the power, however in my previous unit I was using the generic implementation and was working, I was wondering if I can input the basics of the state from the generic into the whirlpool class just to populate the already formed values. I am trying to write the less code possible to be able to maintain it clean if possible

greetings

[crankyoldgit]

Can you expand on what you mean when you say "I was using the generic implementation"? I'm having difficulty understanding what your trying to do, and what you have previously done.

[beckmx]

Sure, I have this code:

IRac ac(kIrLed);
      ac.next.protocol = (decode_type_t)current_brand;
    ac.next.model = 1;  
    ac.next.mode = stdAc::opmode_t::kCool;  
    ac.next.celsius = true; 
    ac.next.degrees = 25; 
    ac.next.fanspeed = stdAc::fanspeed_t::kHigh; 
    ac.next.swingv = stdAc::swingv_t::kOff; 
    ac.next.swingh = stdAc::swingh_t::kOff;  
    ac.next.light = false; 
    ac.next.beep = true;  
    ac.next.econo = false;  
    ac.next.filter = false;  
    ac.next.turbo = false;
    ac.next.quiet = false;
    ac.next.sleep = -1;  
    ac.next.clean = false;
    ac.next.clock = -1;  
    ac.next.power = false; 

I would like to use the already configured state to feed the IRWhirlpoolAc class, something similar like this

IRWhirlpoolAc::toCommon

But in the inverse from common to IRWhirpoolAc

[crankyoldgit]

Unfortunately, there doesn't exist a convenient method to convert a stdAc::state_t into a specific IRWhirlpoolAC object state. There just hasn't been a pressing need for it, or a practical use case for it.

The best I can suggest is copy the code from:

IRremoteESP8266/src/IRac.cpp

Lines 2731 to 2768 in e52495f

	#if SEND_WHIRLPOOL_AC
	/// Send a Whirlpool A/C message with the supplied settings.
	/// @param[in, out] ac A Ptr to an IRWhirlpoolAc object to use.
	/// @param[in] model The A/C model to use.
	/// @param[in] on The power setting.
	/// @param[in] mode The operation mode setting.
	/// @param[in] degrees The temperature setting in degrees.
	/// @param[in] fan The speed setting for the fan.
	/// @param[in] swingv The vertical swing setting.
	/// @param[in] turbo Run the device in turbo/powerful mode.
	/// @param[in] light Turn on the LED/Display mode.
	/// @param[in] sleep Nr. of minutes for sleep mode. -1 is Off, >= 0 is on.
	/// @param[in] clock The time in Nr. of mins since midnight. < 0 is ignore.
	void IRac::whirlpool(IRWhirlpoolAc *ac, const whirlpool_ac_remote_model_t model,
	const bool on, const stdAc::opmode_t mode,
	const float degrees,
	const stdAc::fanspeed_t fan, const stdAc::swingv_t swingv,
	const bool turbo, const bool light,
	const int16_t sleep, const int16_t clock) {
	ac->begin();
	ac->setModel(model);
	ac->setMode(ac->convertMode(mode));
	ac->setTemp(degrees);
	ac->setFan(ac->convertFan(fan));
	ac->setSwing(swingv != stdAc::swingv_t::kOff);
	// No Horizontal swing setting available.
	// No Quiet setting available.
	ac->setSuper(turbo);
	ac->setLight(light);
	// No Filter setting available
	// No Clean setting available.
	// No Beep setting available.
	ac->setSleep(sleep >= 0); // Sleep is either on/off, so convert to boolean.
	if (clock >= 0) ac->setClock(clock);
	ac->setPowerToggle(on);
	ac->send();
	}
	#endif // SEND_WHIRLPOOL_AC