Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting links (link to entry) broken. this.caret undefined #61

Closed
stenvdb opened this issue Jun 14, 2018 · 16 comments
Closed

Inserting links (link to entry) broken. this.caret undefined #61

stenvdb opened this issue Jun 14, 2018 · 16 comments
Assignees
Labels

Comments

@stenvdb
Copy link

stenvdb commented Jun 14, 2018

When inserting a link (link to entry) I get a JavaScript error when slecting an entry.
TypeError: this.caret is undefined
In redactor.js:12486:12. I'm on the latest version of redactor and Craft 3.0.10.3. The site has two locales (= 2 sites).

@andris-sevcenko
Copy link
Contributor

When you say "latest version" is that the latest released version of the latest commit to the repository?

@stenvdb
Copy link
Author

stenvdb commented Jun 15, 2018

Ah yes, sorry if I wasn't specific, I'm at 2.1.0

@andris-sevcenko
Copy link
Contributor

Hmm, I'm unable to reproduce on that one either. Can you upload a screencast so I can see if I'm maybe missing a step or I'm doing it differently?

@stenvdb
Copy link
Author

stenvdb commented Jun 15, 2018

Of course: https://www.dropbox.com/s/u8b5crv9tfgg4ph/redactor-bug.mov?dl=0
If you want I can give you an account to the site if you want to look into it a bit further?

@andris-sevcenko
Copy link
Contributor

Huh, still unable to reproduce. Can you, please, shoot account information over to support@craftcms.com and reference this issue?

@andris-sevcenko
Copy link
Contributor

I'm unable to reproduce on your site, either. Have you tried clearing your browser's cache? If you type $R.version in your developer console, what do you get?

@stenvdb
Copy link
Author

stenvdb commented Jun 18, 2018

3.0.9,
I just tested this in Chrome, where it actually works. I'm getting the error in Firefox. Can you reproduce it in Firefox (latest version)?

@andris-sevcenko
Copy link
Contributor

@stenvdb Sorry for the long delay. I'm still unable to reproduce on Firefox 61.0.1

@stenvdb
Copy link
Author

stenvdb commented Jul 6, 2018

Weird.. I still have this issue on Firefox 61.0.1. Have you tested this on my site with the credentials I sent over? I can reproduce this error even when I login using a tool like browserstack.

@andris-sevcenko
Copy link
Contributor

@stenvdb finally was able to reproduce. We just released Redactor 2.1.1, can you update to that and see if that fixes the issue?

@andris-sevcenko andris-sevcenko self-assigned this Jul 13, 2018
@stenvdb
Copy link
Author

stenvdb commented Jul 13, 2018

Hi @andris-sevcenko unfortunately not :( Updated to 2.1.1 but exact same error in the same place still occurs. I updated our live site as well, so if you find the time, you can still test with the credentials I sent you a while back.

@andris-sevcenko
Copy link
Contributor

Okay, was able to reproduce locally, finally. Looking into it.

@andris-sevcenko
Copy link
Contributor

@stenvdb traced it down to a bug in Redactor itself (even the latest 3.1). I submitted a bug report, hopefully it's fixed soon.

@andris-sevcenko
Copy link
Contributor

Still unfixed as of Redactor 3.1.1

@andris-sevcenko
Copy link
Contributor

@stenvdb to clarify, you should not be seeing this.caret is undefined error, but your links might exhibit the symptoms outlined in #69, so closing this as a duplicate now.

@stenvdb
Copy link
Author

stenvdb commented Aug 21, 2018

@andris-sevcenko Perfect, will subscribe to #69 so I'll know when Redactor releases a fix. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants