Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Issue - Pagination URL is null if pagination node key contains a . #1384

Open
leighgibbo opened this issue Nov 21, 2023 · 0 comments
Labels

Comments

@leighgibbo
Copy link

Description

TL;DR: In the settings for "Pagination URL", selecting a node with a dot in it, results in a null value for paginationUrl being returned for each respective job, and pagination does not work.

Selecting a pagination URL node key that contains a period . saves the feed config as expected 🙂, but prevents the actual jobs from fetching the correct URL 🙁, as the HASH::get method will split the supplied key into arrays to allow for some simple dot-notation parsing.

Steps to reproduce

  1. Connect to a feed that returns nodes with periods/dots in the keys, such as an oData API (returns things like @odata.nextLink, or @odata.count)
  2. Select a key with a period contained
  3. Run the job and check the Job's Data in Queue Manager - the paginationUrl will be null

Additional info

  • Craft version: 4.5.5
  • PHP version: 8.1.21
  • Database driver & version: MariaDB-1:10.4.30
  • Plugins & versions: FeedMe 5.0.4
@leighgibbo leighgibbo added the bug label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant