-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian Package - Disable function /tests with construction errors #350
Comments
Hi there, thanks for this information. The page you linked only designates which tests were removed (and shows that they were commented out), but doesn't explain why they were removed. We have Travis set up and all tests are currently passing so I'm not sure why any would need to be removed. https://travis-ci.org/craffel/mir_eval |
Hey! Here are the errors: ERROR: test_input_output.test_load_tempoTraceback (most recent call last): ======================================================================
|
No, these are all useful tests that currently pass. All of the errors you have look like they are because the test files can't be found. Did you include the test files in the debian package? |
not.
debian does not allow us to make any changes.
When we make a patch, it is only applied at build time.
but the files remain original.
Would you have any solution?
Obter o Outlook para Android<https://aka.ms/AAb9ysg>
…________________________________
From: Colin Raffel ***@***.***>
Sent: Thursday, August 4, 2022 12:50:17 PM
To: craffel/mir_eval ***@***.***>
Cc: Nilsonfsilva ***@***.***>; Author ***@***.***>
Subject: Re: [craffel/mir_eval] Debian Package - Disable function /tests with construction errors (Issue #350)
Would there be a way to change them, disable them or even remove them? So I wouldn't need to fix your code.
No, these are all useful tests that currently pass. All of the errors you have look like they are because the test files can't be found. Did you include the test files in the debian package?
—
Reply to this email directly, view it on GitHub<#350 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVZIS76EOC4SNXRUFBX42PDVXPRDTANCNFSM55EG32IA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
If the files are indeed included, the problem appears to be that Debian's test system is not finding them (e.g. |
I have sorted out the patch noise. Maybe you want to take another look. |
would you like to launch a new tag?
I need it for repackaging.
I'm waiting
Obter o Outlook para Android<https://aka.ms/AAb9ysg>
…________________________________
From: bgermann ***@***.***>
Sent: Sunday, October 2, 2022 6:57:15 PM
To: craffel/mir_eval ***@***.***>
Cc: Nilsonfsilva ***@***.***>; Author ***@***.***>
Subject: Re: [craffel/mir_eval] Debian Package - Disable function /tests with construction errors (Issue #350)
I have sorted out the patch noise. Maybe you want to take another look.
—
Reply to this email directly, view it on GitHub<#350 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVZIS745PCWYNFI5RDAOTFLWBIALXANCNFSM55EG32IA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi!
I would like to inform you that your project will enter the official Debian repositories.
However, I had to disable several test file functions.
If you are interested in investigating them, follow the link:
https://salsa.debian.org/debian/mir-eval/-/blob/debian/master/debian/patches/
If you fix them in the next version, they will be merged into the debaian package.
thankful!
Nilson Silva
The text was updated successfully, but these errors were encountered: