Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technical expiry date #96

Open
kevonfernando opened this issue Sep 6, 2021 · 10 comments
Open

Add technical expiry date #96

kevonfernando opened this issue Sep 6, 2021 · 10 comments
Labels
enhancement New feature or request priority:high

Comments

@kevonfernando
Copy link

It would be nice to have the technical expiry date of the certificate on the back of the card. That would further make a great place to have a link back to the website, for when users need to create a new pass for a new certificate. Also, does the pass itself expire with the certificate?

@JantsoP
Copy link

JantsoP commented Sep 6, 2021

Well there is end date of all certificates on 30.6.2022 as mandated by EU and confirmed by Finnish Health Institute when I asked them about this few months back. On my instance, I have added the date.
6A74236C-8E4C-47F5-8E46-67260055CCFF
If the certificates get continued, they (Health institutes) will probably will update backends so when you go get new QR code, it has updated info.

@marvinsxtr
Copy link
Member

I like the idea of having a link to the site on the back of the pass. Currently the passes do not have a technical expiry date from CovidPass's side but we could define it to be the one saved in the QR payload as described in the specification. I do not know what date they save in there though and how it affects the validity.

@marvinsxtr
Copy link
Member

The specification states the following:

The Expiration Time (exp) claim SHALL hold a timestamp in the integer NumericDate format (as specified in RFC 8392 section 2) indicating for how long this particular signature over the Payload SHALL be considered valid, after which a Verifier MUST reject the Payload as expired. The purpose of the expiry parameter is to force a limit of the validity period of the health certificate. The Claim Key 4 is used to identify this claim. The Expiration Time MUST not exceed the validity period of the DSC.

As many do not even scan the code to verify the pass, it should definitely expire. This is also supported by Apple Wallet.

@marvinsxtr marvinsxtr added enhancement New feature or request priority:high labels Oct 12, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Oct 13, 2021

Please note the following:

There is this video shared by the BMG on Twitter, which says this:

image

@JantsoP
Copy link

JantsoP commented Oct 13, 2021

For above: This is something I mentioned already on my own comment above :) #96 (comment)

EDIT: I also made PR #43 about this, but it was declined.

@marvinsxtr
Copy link
Member

Starting in February, certificates will expire after 9 months as recently announced by the EU commission.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Dec 25, 2021

@marvinsxtr Please note that this is only the case for intra-EU traveling, not necessarily also for entry to venues in Germany.

@marvinsxtr
Copy link
Member

Do you have a suggestion of how we should handle this? I would like to align with CovPass Check and Corona-Warn-App here.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Dec 25, 2021

No idea how they will handle this, I opened issues reg. this: Digitaler-Impfnachweis/covpass-ios#88 & corona-warn-app/cwa-wishlist#726.

@marvinsxtr marvinsxtr changed the title Add technical expiry date and website link to pass Add technical expiry date Dec 26, 2021
@marvinsxtr
Copy link
Member

The link to CovidPass was added with #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high
Projects
None yet
Development

No branches or pull requests

4 participants