Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate selection does not work #35

Open
mathis-aymonin opened this issue Jul 13, 2021 · 40 comments
Open

Certificate selection does not work #35

mathis-aymonin opened this issue Jul 13, 2021 · 40 comments
Labels
help wanted Extra attention is needed not reproducible The described Bug is not reproducible priority:highest

Comments

@mathis-aymonin
Copy link

mathis-aymonin commented Jul 13, 2021

First of all, thank you for this project!

Click on "Start Camera" or "Select File" does nothing (see the attached video).
Safari has permission to access the microphone and camera.

iPhone 6
iOS 12.5.4

issue_covidpass.mov
@marvinsxtr marvinsxtr added not reproducible The described Bug is not reproducible help wanted Extra attention is needed priority:high labels Jul 13, 2021
@JantsoP
Copy link

JantsoP commented Jul 21, 2021

Can confirm this bug. Had to dig out my old iPhone 6 just to test this.

@marvinsxtr
Copy link
Member

@JantsoP Do you want to look into this? None of the contributors has an iPhone 6 or older, so we can't really work on this. We might need to check if we can reproduce this in the Xcode simulator but I don't think it will be easy to debug the camera view in this way.

@JantsoP
Copy link

JantsoP commented Jul 21, 2021

@marvinsxtr Can do. Already downloading xCode on my MacBook due was gonna debug my own instance why the file download failed. But I got that sorted so now I can look into this. I will get back to you with logs probably tomorrow.

@JantsoP
Copy link

JantsoP commented Jul 22, 2021

Screenshot 2021-07-22 at 12 48 15

Screenshot 2021-07-22 at 12 47 42

The first picture is from iPhone 6 safari console and second is from my iPhone 12 Pro Max. So looks like there is a misplaced dot which then breaks the whole thing? Since I just tested even just doing it as blank, it did not give any errors. But on iPhone 12 Pro Max i got the "Please scan..." error.

This also can be duplicated on xCode simulators. Tested with iPhone 6 with 12.4 and then iPhone 12 Pro Max.
On iPhone 6, I got same errors as physical phone. On iPhone 12 Pro Max sim, everything worked just fine.

@lpayet-dotcom
Copy link

I have exaclty the same issue on iOS 13.2.3 (iPhone 11) if it can help to solve.

@Torpidlittle
Copy link

I have the exact same issue. Doesn’t work on iPhone 6, iOS 12.5.4.
Thanks to fix this!

@SomeusernameX
Copy link

Can confirm, not working on iOS 12.4 either

@kpbearfl
Copy link

It worked for my first two doses, it's not working for the third, iOS 15.2 on iPhone XR

@ferlenga
Copy link

It worked for my first two doses, it's not working for the third, iOS 15.2 on iPhone XR

I have exactly the same issue, iOS 14.8.1 on iPhone 7

@Izhocel
Copy link

Izhocel commented Jan 1, 2022

It worked for my first two doses, it's not working for the third, iOS 15.2 on iPhone XR

Same issue here with iphone XR and 11 under iOS 15.1 but worked with iPad Pro under iOS 15.1

@marvinsxtr
Copy link
Member

Could you check if you enabled JavaScript (Settings -> Safari -> Advanced)? Also it would be helpful if someone with a Mac could send the logs when trying to interact with the buttons. See this tutorial.

@Izhocel
Copy link

Izhocel commented Jan 2, 2022

Yes I have JavaScript enabled on safari.
Ok I will try to send you the logs

@Izhocel
Copy link

Izhocel commented Jan 2, 2022

I have followed the tutorial to get access to the web inspector. What do I have to do now to get the logs when I interact with the buttons ?

@marvinsxtr
Copy link
Member

I never used it but there should be a console tab somewhere. Google will probably help you to find it.

@Izhocel
Copy link

Izhocel commented Jan 2, 2022

Ok I found it
Nothing appears in the console When I click on the camera button and this is the same from safari on macOS while it is working from brave on macOS

@ferlenga
Copy link

ferlenga commented Jan 2, 2022

Yes I have JavaScript enabled on safari.
Ok I will try to send you the logs

Same with me

@marvinsxtr
Copy link
Member

marvinsxtr commented Jan 2, 2022

Are all buttons/links not working? When I disable JS, the Add to Wallet button works i.e. the form is submitted, is that the case for you too? Maybe also try to turn off pop-up blocking in Settings > Safari > Block pop-ups.

@Izhocel
Copy link

Izhocel commented Jan 2, 2022

All buttons are not working except for the privacy policy and the add to wallet button.
I can accept the policy and when i click on the add to wallet button the page is reloaded

@marvinsxtr
Copy link
Member

Do you have any extensions installed (Settings > Safari > Extensions)?

@Izhocel
Copy link

Izhocel commented Jan 2, 2022

No i don’t

@ferlenga
Copy link

ferlenga commented Jan 2, 2022

Are all buttons/links not working? When I disable JS, the Add to Wallet button works i.e. the form is submitted, is that the case for you too? Maybe also try to turn off pop-up blocking in Settings > Safari > Block pop-ups.

When I click on “select a file”, nothing happen. Doing it on an iPhone 13 a pop up appears for file selection.

@marvinsxtr
Copy link
Member

@marvinsxtr marvinsxtr changed the title Certificate selection does not work on iPhone 6 Certificate selection does not work Jan 4, 2022
@Izhocel
Copy link

Izhocel commented Jan 4, 2022

I tried to debug with your links, but still the same issue.
The property cursor: pointer was already applied to the button role
The z-index: 1000 didn't change anything

Capture d’écran 2022-01-04 à 19 54 28

@marvinsxtr
Copy link
Member

marvinsxtr commented Jan 4, 2022

Have you also tried removing the hover: and focus: classes and onTouchStart in addition to onClick?

@Izhocel
Copy link

Izhocel commented Jan 4, 2022

Where can I find onTouchStart in addition to onClick?
Removing the hover: and focus: classes didn't change anything

@marvinsxtr
Copy link
Member

In button.tsx try to add onTouchStart={props.onClick} below onClick={props.onClick}.

@Izhocel
Copy link

Izhocel commented Jan 4, 2022

Sorry I don't find it

@marvinsxtr marvinsxtr pinned this issue Jan 4, 2022
@Willy-JL
Copy link

Willy-JL commented Jan 4, 2022

I can't help with debugging since I don't have a Mac, but I can confirm this happens to me and my friend too. I'm on iPhone 12 and he's on iPhone 11 Pro, both using Safari, but also tried Brave and Aloha, still nothing. We are both on iOS 14, to be precise I'm on iOS 14.4.2, he's on iOS 14.4.1. We are staying behind for jailbreak purposes but we both tried rebooting the phones into an unjailbroken state and it still doesn't work, so that's not the issue.

EDIT: We also both have JavaScript enabled, and don't have any extensions since iOS 14 doesn't even support them.

@Izhocel
Copy link

Izhocel commented Jan 8, 2022

FYI, I have updated my iPhone to iOS 15.2 and now it's working well

@ferlenga
Copy link

ferlenga commented Jan 9, 2022

FYI, I have updated my iPhone to iOS 15.2 and now it's working well

Me too!!!

@marvinsxtr
Copy link
Member

May or may not be fixed with the newest release.

@marvinsxtr
Copy link
Member

Can someone who has this issue confirm?

@Willy-JL
Copy link

Still broken for me :/
I did it by doing it on pc and then transferring the .pkpass to the phone manually. It didn't recognize as a real pass so I had to host it on a temporary local web server and download it that way for it to recognize.
But no, doing it on phone still doesn't work for me.

@marvinsxtr
Copy link
Member

Someone with this issue will have to debug this.

@Super-Tomate
Copy link

Super-Tomate commented Jan 16, 2022

Hi,
I’m on IPhone 11 Pro, iOS 14.8, and I have exactly the same problem : "Start Camera" or "Select File" button doesn’t work. The same way we can see in the video.

I also in safari.

Best regard.

@marvinsxtr
Copy link
Member

marvinsxtr commented Jan 16, 2022

@Willy-JL Could you try to debug this? I'm afraid a Mac would not be very helpful as there does not seem to be an error message anyway.

@marvinsxtr
Copy link
Member

marvinsxtr commented Jan 16, 2022

For anyone trying to debug this:

Clone the repo, make sure Node.js is installed and run:

npm install --global yarn
yarn install
yarn dev

Then connect to <local IP of your device>:3000 on your phone.

Note that generating a pass will not be possible, however this is sufficient to test the buttons.

@MagicLegend
Copy link

MagicLegend commented Feb 10, 2022

@marvinsxtr I can confirm this is still an issue on the current live site (as per #169). Testing in Browserstack revealed no error logging. If you have additional changes to be tested feel free to send me a ping.

@marvinsxtr
Copy link
Member

@MagicLegend I will not be rolling out additional changes just for testing. Someone with the error will have to do trial and error to fix this. Any other approach is too tedious imo.

@MagicLegend
Copy link

@marvinsxtr You can get unlimited free access to Browserstack for this project, since it's open source. That way you can easily test it yourself as well :) But I might have a look at it sometime later as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed not reproducible The described Bug is not reproducible priority:highest
Projects
None yet
Development

No branches or pull requests