Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #21

Open
marvinsxtr opened this issue Jun 30, 2021 · 37 comments
Open

Localization #21

marvinsxtr opened this issue Jun 30, 2021 · 37 comments
Labels
enhancement New feature or request

Comments

@marvinsxtr
Copy link
Member

Localize the web app for all EU countries.

@marvinsxtr marvinsxtr added the enhancement New feature or request label Jun 30, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jun 30, 2021

I would like to help with the localization.
So if you prepare the codebase, feel free to ping me here and I can take over the German translation (and can also take a look at the French one - no promise I can translate everything in high quality there).

@hauketoenjes
Copy link
Member

Hi, thanks for your offer 👍🏼

We will prepare the codebase while we transition to typescript (Issue #20). We will leave this open and inform you as soon as we did that.

@marvinsxtr
Copy link
Member Author

@Ein-Tim The localization branch is now ready for the German translation.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 2, 2021

@marvinsxtr

Thanks for the update, I'll take a look at it later and will probably start with the translation tomorrow/on Sunday.

If I need any advice or help, I can surely ping you here, right?

@marvinsxtr
Copy link
Member Author

Of course!

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 3, 2021

Okay, so I took a look at the codebase, I assume I'll do the following:
Create a new folder "locales/de" here, copy the files from "locales/en" there and then just translate.

Do I have to translate any other files (which are providing the strings for the actual wallet card?

@marvinsxtr
Copy link
Member Author

That's right, you can also add "de" to the locales list in next-i18next.config.js. We will handle translation of the wallet card on the server, that's why it is not included.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 3, 2021

@marvinsxtr

I now added the first translation to the files common.yml, errors.yml & index.yml with https://github.com/Ein-Tim/covidpass/commit/cbef4bea76d758b55b19e49ff9df265db295c3df.
I did not (yet) translate the imprint.yml & privacy.yml files, since these are legal texts and I assume you would like to do this (also the Imprint seems to have been translated from German to English already, and if I now would translate English to German again, I assume this sounds a bit odd).

Not sure how to modify next-i18next.config.js, I would like to leave this to you.

Should I provide a PR with my current changes or is there anything else left to do?

@marvinsxtr
Copy link
Member Author

Thanks for the contribution, you are right with the legal stuff, that would be odd. Feel free to open a PR.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 3, 2021

PR #26 is open for this.

A little site note, the text is currently "Add your EU Digital Covid Vaccination Certificates to your favorite wallet app.", maybe we should remove "Vaccination" since this tool also supports recovered and tested certificates, or?

@marvinsxtr
Copy link
Member Author

It doesn't yet but we will remove that as soon as we support these certificates.

@marvinsxtr marvinsxtr pinned this issue Jul 3, 2021
@j3r3m067
Copy link
Contributor

I can translate in French if you want ;)

@marvinsxtr
Copy link
Member Author

@j3r3m067 That would be great! Would you also do the privacy policy and imprint? The latter is less important but would be nice for consistency. Otherwise just copy the english translation :)

@marvinsxtr
Copy link
Member Author

Dutch and Finnish translations are now finished. See #48.

@everdrone
Copy link
Contributor

Hi, love the project
I can translate in Italian

@marvinsxtr
Copy link
Member Author

@everdrone Great! Feel free to open a PR :)

@vebaev
Copy link

vebaev commented Jul 26, 2021

I can help with Bulgarian if needed.

@marvinsxtr
Copy link
Member Author

@vebaev The goal is to translate it for all EU countries, so I would appreciate it :)

@mcvendrell
Copy link
Contributor

mcvendrell commented Jul 30, 2021

Hi guys, I'm ready for spanish translation.
It is just to translate the locale/en to locale/es and add to next-i18next.config.js? Nothing more?

It is done. Sending PR now.

@mackonsti
Copy link
Contributor

Hi @marvinsxtr thanks for adding the colour palette to the main page, it's nicer and less complex for translating colours! Are you going to remove the translation keys for the colours then, or should we do this, in some next update? Many thanks!

@marvinsxtr
Copy link
Member Author

@mackonsti I was thinking about using them for alt texts so colorblind people can use the web app too but for that, we would have to translate the new colors too. Apart from that the extra translation keys do no harm i guess.

@unk1nd
Copy link

unk1nd commented Aug 11, 2021

have created a pull-request regarding norwegian translation

@nilaallj
Copy link
Contributor

nilaallj commented Dec 1, 2021

PR sent for Swedish translation! :)

@unk1nd
Copy link

unk1nd commented Dec 6, 2021

#110

Why didn't I get Contributor tag for this :/

@hauketoenjes
Copy link
Member

image

Your commits show in the commit list, but for some reason, GitHub didn't connect them to your account…

@unk1nd
Copy link

unk1nd commented Dec 6, 2021

Did I commit with wrong author config?
Yeah, I did commit with my work email address, have added it to my account so i'm unsure if it will add it now.

commit 980da14ef795f5038940cb3a683c0df3cae0adbf (HEAD -> main, origin/main, origin/HEAD)
Author: Mikael Bendiksen <mikael.bendiksen@b******m.com>
Date:   Wed Aug 11 15:14:21 2021 +0200

    added symlink from no-NB to no folder

commit 5281ff52cade44a72f714da6d720cff6c8eeca82
Author: Mikael Bendiksen <mikael.bendiksen@b******m.com>
Date:   Wed Aug 11 15:13:14 2021 +0200

    norwegian translation

@marvinsxtr
Copy link
Member Author

marvinsxtr commented Dec 6, 2021

@unk1nd Your profile picture is now visible in the commit history for me so that seems to work. You may need to make another contribution though for GitHub to register you as a contributor.

@mackonsti
Copy link
Contributor

mackonsti commented Dec 28, 2021

Hello everyone, Season Greetings!

@marvinsxtr thanks again for your continuing updates!
I just reused the website for a new pass and saw the addition of the new string in index.yml.
Is there a way to notify all translators of new additions so we can add them together at once? (and be notified)

Please, can you kindly change/fix this word that Google Translate killed? 😅
In file /public/locales/el/index.yml
The last new line says share: Συστήσει

It actually is not translated correctly, should be:
share: Κοινοποιήστε το

Thank you for pushing this change the soonest.
Happy new year to you and everyone and your loved ones.

@marvinsxtr
Copy link
Member Author

@mackonsti Fixed it with #144.

@KoNickss
Copy link

KoNickss commented Jan 5, 2022

I can offer to localise it to Romanian, how does this work? do I just open a pull request? where are the localised pages stored?

@marvinsxtr
Copy link
Member Author

marvinsxtr commented Jan 5, 2022

@KoNickss Thank you for your offer. You can create a new folder with your translations in public/locales. There also need to be symlinks and some changes in a config file but I can do that part. Please open a pull request to the localization branch.

@KoNickss
Copy link

KoNickss commented Jan 5, 2022

Ok, I'll do so when I catch some time, thank you for the help and for this awesome project!

@KoNickss
Copy link

KoNickss commented Jan 5, 2022

@marvinsxtr almost done, do I put diacritics or not? Commonly they aren't used when typing in romanian for convenience (since you can tell most words out without them) but they are used in academic and/or professional backgrounds, so do I put them in or not?

@marvinsxtr
Copy link
Member Author

@KoNickss Just do what you find more suiting.

@KoNickss
Copy link

KoNickss commented Jan 5, 2022

@marvinsxtr I am so sorry for bothering you so much and I truly apologise, but I've encountered somewhat of a roadblock, in the privacy file I need to define "the", while in romanian "the" isn't a word, it's a suffix (ul/a) you add to words to make them articulate (Certificate = Certificat; The certificate = Certificatul), so how should I account for this?

@KoNickss
Copy link

KoNickss commented Jan 5, 2022

If 'the' is only applied to phrases like "covid certificate", "privacy policy" or "schema" these are already articulated, so I'll leave the 'the' empty, if any grammar problems arrise I'll sort them out but I doubt there will be any

@marvinsxtr
Copy link
Member Author

marvinsxtr commented Jan 5, 2022

@KoNickss Sounds good. No worries. I don't think the index.yml on the localization branch already has the key share: in it, would be nice if you could add it with the translation as well. (See dev or main for reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests