Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like coursier doesn't override evicted #170

Closed
nafg opened this issue Feb 24, 2016 · 3 comments
Closed

Seems like coursier doesn't override evicted #170

nafg opened this issue Feb 24, 2016 · 3 comments

Comments

@nafg
Copy link

nafg commented Feb 24, 2016

When I run evicted, it causes regular sbt artifact download (even though coursier already downloaded them)

@alexarchambault
Copy link
Member

Looks like this one has to be overridden too...

@alexarchambault alexarchambault added this to the 1.0.0 milestone Mar 22, 2016
@alexarchambault alexarchambault removed this from the 1.0.0 milestone Nov 30, 2016
@alexarchambault
Copy link
Member

alexarchambault commented Mar 15, 2017

Implementing that one should basically "just" be a matter of adding an implementation for the evicted task of sbt (around here, calling a new method in Tasks.scala or a new Evicted.scala file, say).

This task should rely on the value of the coursierResolutions key. The corresponding Resolution knows the whole dependency graph (dependencies lists... the dependencies, rootDependencies the root ones, finalDependencies gives the dependencies of a module - the dependency graph can be walked / explored with these methods). Evicted versions can be identified this way.

@alexarchambault
Copy link
Member

Closing this. evicted should work fine with sbt-lm-coursier (addSbtPlugin("io.get-coursier" % "sbt-lm-coursier" % "2.0.0-RC3-1")), that can be substituted to sbt-coursier. It should also work in the coming releases of sbt 1.3 (> 1.3.0-RC3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants