Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultProps on function components is deprecated #418

Open
davetapley opened this issue Mar 31, 2023 · 1 comment
Open

defaultProps on function components is deprecated #418

davetapley opened this issue Mar 31, 2023 · 1 comment
Labels

Comments

@davetapley
Copy link

Describe the bug

Causes:

Warning: Container: Support for defaultProps will be removed from function components in a future major release.
Use JavaScript default parameters instead.
    at Container
(webpack-internal:///(sc_client)/./node_modules/react-bulma-components/cjs/components/container/container.js:27:23)

Sure enough:

And:

const Container = ({ children, max, breakpoint, className, ...props }) => {

Versions

  • react-bulma-components:: 4.1.0
  • react: 18.2.0

Additional context

https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-defaultprops-on-function-components

77 files need patching. I can do it if maintainer will confirm this is still active and will get merged?

@davetapley davetapley added the bug label Mar 31, 2023
@jirehnimes
Copy link

jirehnimes commented Jul 27, 2023

Up on this one also. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants