Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matcher finds slot start/end via odd means #38

Open
brett19 opened this issue Aug 3, 2018 · 0 comments
Open

Matcher finds slot start/end via odd means #38

brett19 opened this issue Aug 3, 2018 · 0 comments
Assignees

Comments

@brett19
Copy link
Collaborator

brett19 commented Aug 3, 2018

We currently back up the current position by the tokenData length:

startPos -= len(tokenData)

This is probably not entirely safe, and may lead to odd bugs. We should probably update the tokenizer to support fetching the last position, or potentially pass the last position through to matchExec so it can use that.

@brett19 brett19 self-assigned this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant