Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matcher does not support variables on the RHS of an operation #32

Open
brett19 opened this issue Aug 2, 2018 · 1 comment
Open

Matcher does not support variables on the RHS of an operation #32

brett19 opened this issue Aug 2, 2018 · 1 comment
Assignees
@brett19
Labels
bug

Comments

@brett19
Copy link
Collaborator

brett19 commented Aug 2, 2018 •
edited

While the Transformer generates the correct output for this case, the Matcher will then panic if it sees any variables access on the RHS...
@brett19 brett19 added the bug label Aug 2, 2018
@brett19 brett19 self-assigned this Aug 2, 2018
@brett19 brett19 mentioned this issue Aug 2, 2018
Closed
brett19 added a commit to brett19/gojsonsm that referenced this issue Aug 3, 2018
@brett19
Fixes couchbaselabs#5, couchbaselabs#32: Rewrote transformer to calcu…
7941fb8 
…late after nodes correctly.

In a number of different cases, the compiler was incapable of
figuring out the correct place for after nodes.  This also made
it impossible for there to be fields on the RHS of an expression
as the compiler would get confused and incorrectly compile them.
brett19 added a commit that referenced this issue Aug 9, 2018
@brett19
Fixes #5, #32: Rewrote transformer to calculate after nodes correctly.
0ba11ba 
In a number of different cases, the compiler was incapable of
figuring out the correct place for after nodes.  This also made
it impossible for there to be fields on the RHS of an expression
as the compiler would get confused and incorrectly compile them.
@nelio2k
Copy link
Collaborator

nelio2k commented Jan 17, 2019

I think this bug is no longer the case and could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brett19 brett19

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brett19 @nelio2k