Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of redundant shaders #27

Open
8 of 13 tasks
Schneegans opened this issue Sep 2, 2019 · 7 comments
Open
8 of 13 tasks

Reduce the number of redundant shaders #27

Schneegans opened this issue Sep 2, 2019 · 7 comments

Comments

@Schneegans
Copy link
Member

Schneegans commented Sep 2, 2019

There are several classes which are instantiated multiple times with each instance having an identical shader program. This should be optimized! Here are some classes which are affected:

  • WorldSpaceGuiArea.hpp
  • ScreenSpaceGuiArea.hpp
  • Trajectory.hpp
  • Mark.hpp
  • Sunflare.hpp
  • DeepSpaceDot.hpp
  • SimpleBody.hpp
  • Sharad.hpp
  • Ring.hpp
  • PolygonTool.hpp
  • PathTool.hpp
  • EllipseTool.hpp
  • DipStrikeTool.hpp
@JonasGilg JonasGilg self-assigned this Sep 2, 2019
@Schneegans Schneegans added this to the Version 1.2.0 milestone Sep 7, 2019
@JonasGilg JonasGilg removed their assignment Sep 11, 2019
@JonasGilg
Copy link
Member

Someone else can take the ticket for now. In csp-simple-bodies is already a branch, where I started work.

@JonasGilg
Copy link
Member

@Schneegans Why is the Trajectory render logic inside cs-scene, instead of csp-trajectories?
Should I move it over?

@Schneegans
Copy link
Member Author

It's kept in cs-scene since it may be of use for other plugins. I guess we should leave it the way it is for now.

@Schneegans
Copy link
Member Author

I would suggest to move this issue to v1.3.0 together with #62 since it involves some intense refactoring and testing. What do you think?

@JonasGilg
Copy link
Member

Yes, this sounds good.

@Schneegans
Copy link
Member Author

What's the progress on this one? Do you have time to work on this in the near future? Else I would suggest to move this to the next milestone.

@JonasGilg
Copy link
Member

What's the progress on this one?

Close to none. I think this should be done together with a rework of our render pipeline where we have more control, since we don't make much use of the scene graph.

Do you have time to work on this in the near future?

No, sadly not.

Else I would suggest to move this to the next milestone.

Yes we can do that.

@JonasGilg JonasGilg removed this from the Version 1.5.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants