Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the different SED components after a fit #141

Open
cosimoNigro opened this issue May 2, 2023 · 2 comments
Open

Return the different SED components after a fit #141

cosimoNigro opened this issue May 2, 2023 · 2 comments
Assignees

Comments

@cosimoNigro
Copy link
Owner

cosimoNigro commented May 2, 2023

I was asked to add a feature to return the different SED components after a fit.
This would allow for example, to compute the synchrotron and SSC luminosities, separately, after a SSC scenario has been fitted to some MWL data.

Now, we can either return the different SED components (the vu and vuFnu for each radiative process) or we can return a blob with parameters initialised to the best-fit values. The user would then be able to recompute the corresponding radiation by themselves with the normal functions Synchrotron(blob).

Any preference? @sekerby, @jsitarek?

@cosimoNigro cosimoNigro self-assigned this May 2, 2023
@sekerby
Copy link

sekerby commented May 2, 2023

I think that returning nu/nuFnu for each of the components is more general, easier to plot, and would allow for faster computation of the luminosities. Returning a blob with the parameters initialized with best-fit values could be useful for theory considerations, but one could also just initialize that manually after the fact.

@jsitarek
Copy link
Collaborator

jsitarek commented May 2, 2023

Hi,

In principle it can be done already by running the individual processes with the parameters obtained from the fit.
Returning a table of frequencies and SEDs is not a good solution in my opinion, because fits can be done with different processes, so the behaviour of the function will be difficult to describe (e.g. the sequence of SEDs), if you want to go in this direction the best would be to return a dictionary with names of every SED, and then also the blob can be returned, so something like:
blob, table_of_nu, {'Synchrotron': SED_synch, "SSC": SED_SSC, "EC_BLR": SED_BLR, ...}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants