Bug:: Transfer log has errors if Character was Deleted #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
added
bug
itinerare
reviewed
May 22, 2022
|
@itinerare I cleaned it up, and made sure to cover the other |
|
Oh yeah definitely you need it a good amount of times-- just not here! |
itinerare
approved these changes
May 23, 2022
Sabriel-Koh
approved these changes
May 23, 2022
Draginraptor
approved these changes
May 23, 2022
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the Transfer Log will no longer load up and gives an error
"Trying to get property 'url' of non-object" if a character that had been in a transfer was later deleted (and therefore no longer exists to pull information from).
I hide the thumbnail entirely if the character doesn't exist and swap out the
h3content with "Character Deleted".