Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merger of functionality of user character and user sublist pages? #343

Open
SpeedyD opened this issue Jul 15, 2022 · 1 comment
Open

Merger of functionality of user character and user sublist pages? #343

SpeedyD opened this issue Jul 15, 2022 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Jul 15, 2022

Feature Request

This applies specifically to <site>/resources/views/user/characters.blade and <site>/resources/views/user/sublist.blade.

It looks like sublist.blade does pretty much the same thing as characters.blade, aside from the obvious difference that the former shows sublists only. I'm unfortunately unsure how to do this at the current time, but I'm sure there should be some possibility to merge the two.. or.. reuse the functions somehow?

A change I did recently on one of the sites I maintain (Didn't realize sublist was a different function until I found out it didn't work there...) as well as a recent PR (Noticed the PR only affected characters.blade, not sublist.blade...) make me realize that there might in fact be some necessity to this..

@itinerare itinerare added the good first issue Good for newcomers label Jul 16, 2022
@itinerare
Copy link
Collaborator

Noting here as well that it's prob wise to make the character-containing portion of those views a separate widget and incorporate it into both views...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants