Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also test before pushing to registry #13

Open
erlend-aasland opened this issue Mar 3, 2024 · 4 comments
Open

Also test before pushing to registry #13

erlend-aasland opened this issue Mar 3, 2024 · 4 comments

Comments

@erlend-aasland
Copy link
Contributor

In manifest-build-push.yml, we should build and test before pushing. See test-before-push docs for a nice example.
@corona10
Copy link
Owner

corona10 commented Mar 4, 2024

Looks good to me!

@erlend-aasland
Copy link
Contributor Author

Are you working on a PR, or would you like me to propose one?

@corona10
Copy link
Owner

corona10 commented Mar 4, 2024

Are you working on a PR, or would you like me to propose one?

Since you create the issue, I will give you a chance to creating a PR but if you are busy with other stuff, I can do it :)

@erlend-aasland
Copy link
Contributor Author

Right now I'm busy with other stuff. We'll see who gets to it first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corona10 @erlend-aasland