Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untilTag breaks if the tag is not in dicom #104

Open
Djeisen642 opened this issue Sep 28, 2018 · 1 comment · May be fixed by #268
Open

untilTag breaks if the tag is not in dicom #104

Djeisen642 opened this issue Sep 28, 2018 · 1 comment · May be fixed by #268

Comments

@Djeisen642
Copy link

Djeisen642 commented Sep 28, 2018

I've tried out the latest dicomParser, and I'd like to suggest using >= instead of ===. That way when the parser reaches a tag after the tag asked for, it'll stop. Otherwise, I seem to run into some kind of buffer overrun. That also may need to get fixed. If it can't find the tag and it finishes reading the file, it should stop trying to find it.

@JoopAue
Copy link

JoopAue commented Jun 29, 2022

I would also very much appreciate this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants