CoreShop\Bundle\CoreBundle\EventListener\NotificationRules\OrderWorkflowListener same state in both from and to

[dkarlovi]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no

When the listener is handling Symfony\Component\Workflow\Event\CompletedEvent, the marking is already in the "to" state, but currently it's assuming the transition is still to take place:

CoreShop/src/CoreShop/Bundle/CoreBundle/EventListener/NotificationRules/OrderWorkflowListener.php

Lines 48 to 49 in eda4722

	'fromState' => $event->getMarking()->getPlaces(),
	'toState' => $event->getTransition()->getTos(),

At this time, the marking already changed and the "to" should be read from it, not "from".

[dkarlovi]

@dpfaffenbauer this is a bug. 😄