From 3c937b484c38b864106c7b95d18476c8fc6ae2f8 Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Thu, 25 Apr 2024 12:49:03 +0200 Subject: [PATCH 1/2] reimplement existing data check in ProductQuantityPriceRulesCloner --- .../Core/Product/Cloner/ProductQuantityPriceRulesCloner.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php b/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php index a611242951..46d761f9aa 100644 --- a/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php +++ b/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php @@ -47,6 +47,11 @@ public function clone( } $quantityPriceRules = $referenceProduct->getQuantityPriceRules(); + $hasQuantityPriceRules = is_array($product->getQuantityPriceRules()) && count($product->getQuantityPriceRules()) > 0; + + if ($hasQuantityPriceRules === true && $resetExistingData === false) { + return; + } /** * @var Concrete&ProductInterface $referenceProduct From 7f39cd10c45e1ebbf94f94310433695ca49b7d8f Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Thu, 25 Apr 2024 13:04:20 +0200 Subject: [PATCH 2/2] remove redundant check --- .../Core/Product/Cloner/ProductQuantityPriceRulesCloner.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php b/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php index 46d761f9aa..53a0f06a97 100644 --- a/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php +++ b/src/CoreShop/Component/Core/Product/Cloner/ProductQuantityPriceRulesCloner.php @@ -47,7 +47,7 @@ public function clone( } $quantityPriceRules = $referenceProduct->getQuantityPriceRules(); - $hasQuantityPriceRules = is_array($product->getQuantityPriceRules()) && count($product->getQuantityPriceRules()) > 0; + $hasQuantityPriceRules = count($product->getQuantityPriceRules()) > 0; if ($hasQuantityPriceRules === true && $resetExistingData === false) { return;