Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

backup s3 credential keys escaping is broken #2114

Open
fdlk opened this issue Aug 26, 2019 · 0 comments
Open

backup s3 credential keys escaping is broken #2114

fdlk opened this issue Aug 26, 2019 · 0 comments

Comments

@fdlk
Copy link

fdlk commented Aug 26, 2019

If your s3 credentials contain a # character, the backup and restore will fail because the credentials are truncated at the # sign.

E.g. if .aws/credentials contains

[default]
aws_access_key_id=KS5n4dV4ZhmjrvpZJmSP
aws_secret_access_key=mr2Xc^y#AWTZ92NWJ#m^NBABZ!js&M#hPqRmD4ps

This is a bug in aws go api < v1.15.59 which used to depend on go-ini/ini which contains go-ini/ini#187

Bug is fixed in https://github.com/aws/aws-sdk-go/releases/tag/v1.15.59 when they introduced an internal ini parser.

A couple new bugs were introduced by that parser, e.g. aws/aws-sdk-go#2281

Last one got fixed in v1.15.79.

Would suggest to upgrade aws dependency to at least 1.15.x or otherwise using environment variables instead of the aws ini file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant