Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance configuration of dnstap plugin #4198

Closed
rdrozhdzh opened this issue Oct 13, 2020 · 2 comments · May be fixed by #6643
Closed

Enhance configuration of dnstap plugin #4198

rdrozhdzh opened this issue Oct 13, 2020 · 2 comments · May be fixed by #6643

Comments

@rdrozhdzh
Copy link
Contributor

What would you like to be added:

Plugin dnstap should support configuration options for allowed types of DNSTAP messages.
The config may look like

  dnstap tcp://127.0.0.1:9123 full CR FR

where all parameters after endpoint are optional
or

  dnstap tcp://127.0.0.1:9123 full {
    allow CR FR
  }

Other plugins should be able to check these config options. Bunch of booleans is ok.
See also #4179 (comment) for reference

Why is this needed:
PR #4179 removed the ability to disable CQ and/or CR messages with flags passes via context.
Adding the configuration options to dnstap plugin will restore ability to control generation of dnstap messages of particular types.

Note, other popular DNS servers (e.g. unbound) also have similar configuration options.

@miekg
Copy link
Member

miekg commented Oct 15, 2020

I would prefer the second syntax and probable s/allow/options/. Potentially also not using the abbreviations, because 'CR', 'FR' require deep knowledge of dnstap

@miekg
Copy link
Member

miekg commented Mar 3, 2021

no one is picking this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants