Skip to content

Latest commit

 

History

History
75 lines (46 loc) · 4.01 KB

CODE_OWNERS.rst

File metadata and controls

75 lines (46 loc) · 4.01 KB

TTS code owners / governance system

TTS is run under a governance system inspired (and partially copied from) by the Mozilla module ownership system. The project is roughly divided into modules, and each module has its owners, which are responsible for reviewing pull requests and deciding on technical direction for their modules. Module ownership authority is given to people who have worked extensively on areas of the project.

Module owners also have the authority of naming other module owners or appointing module peers, which are people with authority to review pull requests in that module. They can also sub-divide their module into sub-modules with their owners.

Module owners are not tyrants. They are chartered to make decisions with input from the community and in the best interest of the community. Module owners are not required to make code changes or additions solely because the community wants them to do so. (Like anyone else, the module owners may write code because they want to, because their employers want them to, because the community wants them to, or for some other reason.) Module owners do need to pay attention to patches submitted to that module. However “pay attention” does not mean agreeing to every patch. Some patches may not make sense for the WebThings project; some may be poorly implemented. Module owners have the authority to decline a patch; this is a necessary part of the role. We ask the module owners to describe in the relevant issue their reasons for wanting changes to a patch, for declining it altogether, or for postponing review for some period. We don’t ask or expect them to rewrite patches to make them acceptable. Similarly, module owners may need to delay review of a promising patch due to an upcoming deadline. For example, a patch may be of interest, but not for the next milestone. In such a case it may make sense for the module owner to postpone review of a patch until after matters needed for a milestone have been finalized. Again, we expect this to be described in the relevant issue. And of course, it shouldn’t go on very often or for very long or escalation and review is likely.

The work of the various module owners and peers is overseen by the global owners, which are responsible for making final decisions in case there's conflict between owners as well as set the direction for the project as a whole.

This file describes module owners who are active on the project and which parts of the code they have expertise on (and interest in). If you're making changes to the code and are wondering who's an appropriate person to talk to, this list will tell you who to ping.

There's overlap in the areas of expertise of each owner, and in particular when looking at which files are covered by each area, there is a lot of overlap. Don't worry about getting it exactly right when requesting review, any code owner will be happy to redirect the request to a more appropriate person.

Global owners

These are people who have worked on the project extensively and are familiar with all or most parts of it. Their expertise and review guidance is trusted by other code owners to cover their own areas of expertise. In case of conflicting opinions from other owners, global owners will make a final decision.

  • Eren Gölge (@erogol)
  • Reuben Morais (@reuben)

Training, feeding

  • Eren Gölge (@erogol)

Model exporting

  • Eren Gölge (@erogol)

Multi-Speaker TTS

  • Eren Gölge (@erogol)
  • Edresson Casanova (@edresson)

TTS

  • Eren Gölge (@erogol)

Vocoders

  • Eren Gölge (@erogol)

Speaker Encoder

  • Eren Gölge (@erogol)

Testing & CI

  • Eren Gölge (@erogol)
  • Reuben Morais (@reuben)

Python bindings

  • Eren Gölge (@erogol)
  • Reuben Morais (@reuben)

Documentation

  • Eren Gölge (@erogol)

Third party bindings

Owned by the author.