Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed Files Still Use Memory #751

Open
joscoh opened this issue Mar 11, 2024 · 1 comment · May be fixed by #753
Open

Closed Files Still Use Memory #751

joscoh opened this issue Mar 11, 2024 · 1 comment · May be fixed by #753
Labels
bug Something isn't working

Comments

@joscoh
Copy link

joscoh commented Mar 11, 2024

As mentioned on Zulip, when a file is closed in VSCoq2, the memory is still in use. (I am using VSCoq version 2.1.2) This means that after opening and interactively editing several files, vscoqtop uses huge amounts of memory (>6 GB for 2 files), and there is no way to reduce the memory usage except by closing the VSCode window. In VSCoq legacy, closing a file freed the memory associated with that file's Coq buffer.

@rtetley rtetley added the bug Something isn't working label Mar 12, 2024
@rtetley
Copy link
Collaborator

rtetley commented Mar 13, 2024

Hey @joscoh ! I agree this is a problem. I am working on a fix which would discard the document state / edits when you close a file but that would of course mean re-opening it will require re-executing it (the execution state is probably what is taking up most of the memory). Would that be an acceptable policy ? What do you think @gares ?

@rtetley rtetley linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants