Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phinx migrations dies on fresh install step_3 #197

Open
JJKalnins opened this issue Oct 18, 2017 · 4 comments
Open

Phinx migrations dies on fresh install step_3 #197

JJKalnins opened this issue Oct 18, 2017 · 4 comments

Comments

@JJKalnins
Copy link

Older mysql databases don't support full text indexes

/home/www/website.com/www/public_html/vendor/robmorgan/phinx/src/Phinx/Db/Adapter/MysqlAdapter.php(570):
Phinx\\Db\\Adapter\\PdoAdapter->execute('ALTER TABLE `cp...')
/home/www/website.com/www/cgi-bin/php5-fcgi" stderr: #3 
/home/www/website.com/www/public_html/vendor/robmorgan/phinx/src/Phinx/Db/Adapter/TablePrefixAdapter.php(190):
 Phinx\\Db\\Adapter\\AdapterWrapper->addIndex(Object(Phinx\\Db\\Table), 
Object(Phinx\\Db\\Table\\Index))
General error: 1214 The used table type doesn't support FULLTEXT indexes' in 
/home/www/website.com/www/public_html/vendor/robmorgan/phinx/src/Phinx/Db/Adapter/PdoAdapter.php:338,
 referer: http://website.com/install/index.php?route=install/step_3

There should be some kinda error handle for this

@JJKalnins JJKalnins changed the title Phinx migrations dies on fresh install stap_3 Phinx migrations dies on fresh install step_3 Oct 18, 2017
@arnisjuraga
Copy link
Contributor

arnisjuraga commented Oct 19, 2017

@prhost or @lucasjkr , can You, please, add MySQL version check?
In fact, this would not be a problem to be installed on older MySQLs, (those indexes does not impact CP installation. Those indexes yet are used only by extensions (with MATCH() selects.)

But, if this can't be ignored during the installation, then limitations must be applied during install.

@lucasjkr
Copy link
Contributor

I'll work on the version check, I need it too.

I don't think you should ignore the version though (which I'm assuming you might be thinking about since you're saying it won't have impact? maybe I'm wrong)

@arnisjuraga
Copy link
Contributor

Yes, this was my first thoughts. But of course, it shouldn't. :)

@lucasjkr
Copy link
Contributor

One issue I realized. You can't check the MySQL version as a warning during install (like, where it says what PHP modules are installed), because you can't communicate with the DB to check the version until AFTER you've set up the connection.

Also, you're still pretending to support other databases (MSSQL, Postgres). You should officially end that support if you're going to do this through SQL. Otherwise, wait for @prhost to show off his ORM, and have that do the checking against the DBs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants