A list of visually broken & missing clothing

[BatElite]

A list of things that are or might not be visually correct, mostly (but not all) because they were made in between the resprite and cool forking off.

Did a spawn & equip search using a bunch of concrete_typesof spawners to get one of everything, but cases where icon_state is set in code (medal rewards, maybe others) aren't checked as a result. No comment on whether some of these should be kept in the first place, this is just the state of affairs.

Didn't check things that go on the belt slot (done via a flag so I'd have to corral a bunch of disparate items), and for back-equipped items (also a flag) I only did backpacks which tend to get added to more than other categories. I skipped IDs and headsets because I don't think anything ever got added there between resprite and cool forking.

There might be more misaligned clothing I didn't catch, capitalisation issues are only noted when I found something else wrong with the item I didn't look at the names of anything that looked fine.
Didn't bother with missing inhands because AFAIK that's never not been a shitshow. :)

Jumpsuits:

Mint Diner Waitress's Dress (/obj/item/clothing/under/gimmick/dinerdress_mint) - missing worn state, capitalised post resprite, commented out

Pink Diner Waitress's Dress (/obj/item/clothing/under/gimmick/dinerdress_pink) - missing worn state, capitalised post resprite, commented out

bell bottoms (/obj/item/clothing/under/gimmick/elvis) - missing worn and inventory typo

wannabe pirate outfit (/obj/item/clothing/under/gimmick/guybrush) - missing worn made new sprite

fancy mime suit (/obj/item/clothing/under/misc/mimefancy) - missing worn commented out

mime dress (/obj/item/clothing/under/misc/mimedress) - missing worn commented out

senior botanist's jumpsuit (/obj/item/clothing/under/misc/hydroponics) - missing worn, probably misnamed because this definitely predates the resprite pointed iconstate to old name, works

[purple and blue] medical scrubs (/obj/item/clothing/under/scrub/purple, /obj/item/clothing/under/scrub/blue) - missing worn, I think whoever resprited this also renamed a couple yep, worn sprites were present with -p and -b prefixes, code called for -v and -n

Exosuits

the duke's armor (/obj/item/clothing/suit/armor/vest/abs) - displays fine, but because it's a subtype of the regular armour vests using it in-hand breaks the sprites overridden attack_self

T.U.R.D.S. Tactical Gear (/obj/item/clothing/suit/armor/turd) - missing worn and inventory, capitalised

citadel heavy combat cuirass (/obj/item/clothing/suit/space/syndicate/knight) - missing worn post resprite (sprites anyway), not FOSS

NT-SO forward reconnaissance suit (/obj/item/clothing/suit/space/ntso/scout) - missing inventory

leather overcoat (/obj/item/clothing/suit/space/repo) - missing worn

h (/obj/item/clothing/suit/gimmick/h) - missing worn and inventory

dinosaur pajamas (/obj/item/clothing/suit/gimmick/dinosaur) - missing worn, both with the hood up and down post resprite

leather jacket (/obj/item/clothing/suit/gimmick) - missing worn and inventory, also yes this is the base suit item there's nothing else called a leather jacket

baseball jacket (/obj/item/clothing/suit/jacketsjacket) - worn state misaligned

[dark blue, white, pink, black, grey, dull grey, magenta, green, yellow, red] hoodie (/obj/item/clothing/suit/hoodie/darkblue, /obj/item/clothing/suit/hoodie/white, /obj/item/clothing/suit/hoodie/pink etc., dull grey is /obj/item/clothing/suit/hoodie/dullgrey) - missing worn, that's every colour except blue and orange btw

jacket (/obj/item/clothing/suit/jacket and /obj/item/clothing/suit/jacket/design) - missing worn and inventory, but these are base types and should probably be abstract instead

shoes

shoes (/obj/item/clothing/shoes) - missing worn and inventory, should be abstract

[White, Brown, Navy, black] Mary Janes (/obj/item/clothing/shoes/mjwhite, /obj/item/clothing/shoes/mjbrown, /obj/item/clothing/shoes/mjnavy, /obj/item/clothing/shoes/mjblack) - missing worn post resprite

gloves
(ignoring the wiz spell rings)

Brass Gauntlet (/obj/item/clothing/gloves/brass_gauntlet) - missing worn, capitalised deprecated, sucks

Stungloves (/obj/item/clothing/gloves/stungloves) - missing worn, but that might be because they were directly spawned. Also capitalised

jewelled bracelet (/obj/item/clothing/gloves/psylink_bracelet and /obj/item/clothing/gloves/psylink_bracelet/secondary) - missing worn, might be intentional

Compudyne 0451 Handcomp (/obj/item/clothing/gloves/handcomp) has a worn state but some kind of over/underlay must be missing, capitalised

backpacks

novelty [ultramarine/noise marine] backpack (/obj/item/storage/backpack/ultramarine, /obj/item/storage/backpack/noisemarine) - worn state misaligned

For the rest of these, the matching satchel is also borked

[blue, red, green, brown] backpack (/obj/item/storage/backpack/blue /obj/item/storage/backpack/red /obj/item/storage/backpack/green /obj/item/storage/backpack/brown) - missing worn

[brown, green] turtle shell backpack (/obj/item/storage/backpack/turtlegreen, /obj/item/storage/backpack/turtlebrown) - missing worn, post resprite

bearpack (/obj/item/storage/backpack/bearpack) - missing worn

bag-uette (/obj/item/storage/backpack/breadpack) - missing worn

[black, white] studded backpack (/obj/item/storage/backpack/studdedblack, /obj/item/storage/backpack/studdedwhite) - missing worn

pink itabag [all 5 flavours] - missing worn

Travel pack, rucksack and randoseru satchels - missing worn

masks

Death Commando mask (/obj/item/clothing/mask/gas/death_commando) - missing worn and inventory, capitalised

inquisitor mask (/obj/item/clothing/mask/gas/inquis) - missing worn

mask (/obj/item/clothing/mask) - missing worn and inventory, should be abstract

The Pallid Mask (/obj/item/clothing/mask/pallid) - missing inventory, capitalised

vocal translator (/obj/item/clothing/mask/monkey_translator) - missing worn (possibly intentional), reuses voice changer sprite, typo in description

headwear

captain's space helmet [and colour swaps] (/obj/item/clothing/head/helmet/space/captain) - missing worn

commander's cap (/obj/item/clothing/head/helmet/space/syndicate/commissar_cap) - missing worn

captain's hat [and colour swaps] - inventory icon based on resprite model

heavy specialist great helm (/obj/item/clothing/head/helmet/space/syndicate/specialist/knight) - missing worn

ominous helmet (/obj/item/clothing/head/helmet/space/repo) - missing worn

fruit basket hat (/obj/item/clothing/head/fruithat) - missing worn

werewolf mask[s] - head pixel peeking out the top

giant novelty lizard head (/obj/item/clothing/head/biglizard) - missing worn post resprite

hero hat (/obj/item/clothing/head/link) - missing worn post resprite, commented out

white [top] hat (/obj/item/clothing/head/that/white) - missing worn

long tophat (/obj/item/clothing/head/longtophat) - missing worn

Dramatic Chef's Hat (/obj/item/clothing/head/dramachefhat) - missing worn, capitalised

75-gallon hat (/obj/item/clothing/head/bigtex) - missing worn

large hat (/obj/item/clothing/head/bighat) - missing worn, kinda weird

pinwheel hat (/obj/item/clothing/head/pinwheel_hat) - missing worn

leaf hairclip (/obj/item/clothing/head/headsprout) - missing worn

frog (/obj/item/clothing/head/frog_hat) - missing worn

boater hat (/obj/item/clothing/head/boater_hat) - missing worn

ushanka (/obj/item/clothing/head/ushanka) - missing worn

giraffe ears, bee antennae, leopard ears, snow leopard ears, tiger ears (/obj/item/clothing/head/headband/giraffe, /obj/item/clothing/head/headband/bee, /obj/item/clothing/head/headband/nyan/leopard , /obj/item/clothing/head/headband/nyan/snowleopard, /obj/item/clothing/head/headband/nyan/tiger) - missing worn

diner waitress's hat (/obj/item/clothing/head/waitresshat) - missing worn, post resprite

rafflesia (/obj/item/clothing/head/rafflesia) - missing worn

[every type of hairbow, barettes including butterfly clips] (/obj/item/clothing/head/hairbow/X, /obj/item/clothing/head/barrette/X) - missing worn

[geneva-breaker]

this is great work, very thorough, holy shit tho