Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staticfile settings with cloud provider and whitenoise #5057

Merged
merged 2 commits into from May 13, 2024

Conversation

jkaeske
Copy link
Contributor

@jkaeske jkaeske commented May 7, 2024

The code prevents automatically assuming collectfast strategy and respective staticfile location when whitenoise is selected.
It implements conditional handling for these case:

  • Cloud provider ONLY
  • Whitenoise ONLY
  • Cloud provider AND Whitenoise

Fixes #4925

@browniebroke browniebroke merged commit 88a9a15 into cookiecutter:master May 13, 2024
13 checks passed
@browniebroke
Copy link
Member

Thanks for the fix! Finally found some time to review and give it a spin.

@browniebroke browniebroke changed the title Fix handling of staticfile settings if cloud provider and whitenoise are selected Fix staticfile settings with cloud provider and whitenoise May 13, 2024
@jkaeske jkaeske deleted the whitenoise-cloud-production branch May 14, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting Whitenoise and AWS as cloud provider overrides STATIC_URL in a way that assumes Collectfast
2 participants