Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drain doesn't actually apply to anything on the v3 side of things. #581

Open
beastawakens opened this issue Feb 22, 2023 · 3 comments
Open
Assignees

Comments

@beastawakens
Copy link
Collaborator

Discovered by accident today. The drain configuration in the manifest doesn't apply to any underlying template. k8s doesn't use the same concept of drain like ECS does. Rather it uses the grace termination for the same purpose.
So yeah, whether v3 docs should just update to show that drain is deprecated, or whether you want to merge the two configs behind the scenes somehow, it's up to you!

@beastawakens
Copy link
Collaborator Author

@Twsouza
Copy link
Contributor

Twsouza commented Feb 22, 2023

@beastawakens heron is not active in the project anymore, you can send a message to me if you want.

@beastawakens
Copy link
Collaborator Author

@beastawakens heron is not active in the project anymore, you can send a message to me if you want.

Aah, okay! Might pick your brains about more stuff soon 🤣

@Twsouza Twsouza assigned nightfury1204 and unassigned Twsouza Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants