Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages on small/large GIS features #901

Open
abyrd opened this issue Oct 24, 2023 · 0 comments
Open

Improve error messages on small/large GIS features #901

abyrd opened this issue Oct 24, 2023 · 0 comments
Assignees

Comments

@abyrd
Copy link
Member

abyrd commented Oct 24, 2023

When uploading a shapefile, users may encounter errors like:
"Unable to create opportunity dataset. java.lang.IllegalArgumentException: Feature geometry is too small at com.conveyal.r5.analyst.Grid.getPixelWeights(Grid.java:171)"

Although we do want to avoid processing such tiny features (especially if their near-zero areas end up in denominators) such features can appear in normal data preparation when an original data set is cropped to a study area. Such messages should be demoted to warnings if the error handling code at this point in the backend allows it, otherwise the message should be extended to explain the likely cause to the uploader.

@abyrd abyrd self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant