Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflation of namespace and feedId in RDBMS #142

Open
landonreed opened this issue Sep 17, 2018 · 0 comments
Open

Conflation of namespace and feedId in RDBMS #142

landonreed opened this issue Sep 17, 2018 · 0 comments

Comments

@landonreed
Copy link
Contributor

There are a number of instances in the RDBMS code path where the variable name feedId is used to describe the SQL schema used to namespace feeds stored in the relational database (the format looks something like wxyz_abcdefghij.stops). This could be a bit confusing because feedId is also used frequently in Conveyal's software to mean the field found in the feed_info.txt file. We should first determine how to name this variable (e.g. should we just default to namespace with some parenthetical clarifying its use relative to a feed) and then clean up the files that contain this confusing usage.

Here's an instance where this issue is apparent:

public static FeedLoadResult export (String feedId, String outFile, DataSource dataSource, boolean fromEditor) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant