Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better shape validation #130

Open
landonreed opened this issue Aug 1, 2018 · 1 comment
Open

Better shape validation #130

landonreed opened this issue Aug 1, 2018 · 1 comment
Assignees

Comments

@landonreed
Copy link
Contributor

landonreed commented Aug 1, 2018

Recently some shapes created in the Data Tools editor were discarded during graph building by OTP. To give Data Tools users a sense for when this might happen to their GTFS feeds, I think we should add some functionality similar to the GTFSPatternHopFactory#isValid method.

cc @abyrd

@landonreed landonreed self-assigned this Aug 1, 2018
@abyrd
Copy link
Member

abyrd commented Aug 2, 2018

Should the editor even be capable of creating invalid shapes? What was wrong with the shapes it produced which caused them to be rejected by OTP?

I agree we want to sanity check inputs an outputs as much as possible. My main concern would be maintaining duplicate code - is it possible to design these checks such that they can be reused in GTFS-lib and other projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants