Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashed commits result in issues when the changelog is generated #925

Open
CSergienko opened this issue Sep 8, 2022 · 0 comments
Open
Labels

Comments

@CSergienko
Copy link

CSergienko commented Sep 8, 2022

Describe the bug
Upstream dependency git-semver-tags used in this file does not support squashed commits, resulting in incorrect version numbers being generated in the previousTag.

Current behavior
We use a process of squashing branches before merging into the trunk. Back-merging the trunk into other branches pulls in those squashed commits, where the tag is part of the commit message. git-semver-tags cannot find these tags.

Expected behavior
When squashed commits are back-merged into a branch, semantic-version should be able to parse the tag correctly.

Environment

  • standard-version version(s): v9.3.2
  • Node/npm version: node 16.15.0/npm 8.5.5
  • OS: Windows 10 using Git Bash to emulate *nix environment.

Possible Solution
If no tags are found in the first pass using git-semver-tags, it would be useful to have a fallback to directly parsing output from git tag to find the latest tag. Optionally this could be patched in the upstream dependency.

@CSergienko CSergienko added the bug label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant