Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] NumPy 2.0 support #378

Closed
jakirkham opened this issue Apr 24, 2024 · 2 comments
Closed

[FEATURE] NumPy 2.0 support #378

jakirkham opened this issue Apr 24, 2024 · 2 comments

Comments

@jakirkham
Copy link

Problem description

NumPy 2.0 is coming out soon ( numpy/numpy#24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( numpy/numpy#24300 (comment) )

Proposal

To prepare for NumPy 2.0, it might be worthwhile to start testing against NumPy 2 in CI

NumPy has put out a migration guide. More details are in the release notes

If ContourPy make use of NumPy's C API (and produces wheels that use it), having a release of ContourPy with wheels built against NumPy 2.0.0rc1 would be helpful to ensure NumPy 1 & 2 compatible wheels (as wheels built against NumPy 1 won't be compatible with NumPy 2). More details in this NumPy 2 ABI doc

Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share ContourPy's current support status in issue (with any plans): numpy/numpy#26191

@ianthomas23
Copy link
Member

ContourPy 1.2.1 already supports NumPy 2.0 and has done so for a number of weeks. It is listed in the changelog. It is already listed in the NumPy issue that you are asking for it to be listed on.

@jakirkham I know these issues are auto-generated, but you really should check beforehand to see if they are required rather than waste other developers' time. Now you have a chain of issues linked to this unnecessary one to waste even more peoples' time ...

@jakirkham
Copy link
Author

Apologies Ian. Wasn't intending to create noise or extra work. Sorry for that 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants