Making notcurses happy! #444
Replies: 7 comments 31 replies
-
export the
agreed, looking much better with
you don't want it considered transparent =]. kitty has a feature where the default background color is treated as transparent. i can understand kovid's reasoning for this, but it's a pain in the ass for me, where i want the background i ask for. the "not considered transparent" is a kitty-only thing, where whenever the default background color is used, i have to modify it a tiny bit to work around this behavior. a default background of 0x000000 means a chosen background of 0x000000 becomes 0x000001, for instance. 0xffffff becomes 0xfffffe. you don't want this.
not sure what you mean by this? in Notcurses parlance, a "mosaic" is a graphic broken down into many graphics each having cell size, but i don't yet do this. maybe you mean the diagonal unicode 13 symbols for legacy computing?
cool, no real concern to me save if users are using them; i don't use them myself.
presumably you're running a copy built from git? it's going to look for you'll then see that Contour draws the image on a black background, annihilating the glyphs underneath, unlike other sixel implementations which interpret unspecified pixels as transparent =]. fixing that would be the thing that earned you the most high marks in my book =].
https://sw.kovidgoyal.net/kitty/faq/#some-special-symbols-are-rendered-small-truncated-in-kitty i will take a look at your doc. my current primary practical thought on this is dankamongmen/notcurses#2199. dankamongmen/notcurses#1329 has some thoughts. dankamongmen/notcurses#1904 is not likely to be a solution to IMHO. |
Beta Was this translation helpful? Give feedback.
-
|
I use osx only if i have to. I am primarily using Linux. So i am good damn sorry if it is slow. And therefore i need to fix it . Is this something you feel it just recently got slow or always. Mind there is a branch where i am fully rewritng the internal grid purely for performance. But attention: do not try that yet. I will ping you later for that. :) |
Beta Was this translation helpful? Give feedback.
-
|
For the heuristic replacement, let me first try to talk to other TE devs so that it is at least 3 TEs trying to agree on something. |
Beta Was this translation helpful? Give feedback.
-
Note that transparency is dependent on the Background Select parameter (P2) of the sixel escape sequence. The background should only be transparent if P2 is set to 1. Xterm doesn't handle this correctly, so please don't copy their behaviour exactly. |
Beta Was this translation helpful? Give feedback.
-
|
as is usually the case, my learned colleague @j4james has the right of it here |
Beta Was this translation helpful? Give feedback.
-
|
also, if you might be able to do a non-transparent Sixel more efficiently than P2=1 Sixel, know that i at least do use P2=0 when i have an entirely opaque sixel, so it's probably worth doing the different paths, ymmv. i know foot does this. |
Beta Was this translation helpful? Give feedback.
-
|
oh wow and yes, contour looks MUCH better in |
Beta Was this translation helpful? Give feedback.
-
|
Thanks man. I am not done yet. I will ping you then. :) |
Beta Was this translation helpful? Give feedback.
-
|
how do i turn off your schwarzgerat $ echo -e '\e[4:1merp\e[24mkljlksja' |
Beta Was this translation helpful? Give feedback.
-
|
I'll fix it! Gimme a sec (or two). |
Beta Was this translation helpful? Give feedback.
-
|
Fixed on master that it should. |
Beta Was this translation helpful? Give feedback.
-
|
no, it's always been slow for me. ought i be using some particular compile options? it's probable that i'm running a debug build if that's the default configuration. |
Beta Was this translation helpful? Give feedback.
-
|
Oh yes. But there will also be major(!) Performance improvements imminent. |
Beta Was this translation helpful? Give feedback.
-
|
ahh inded. i have the following in my if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE
STRING "Choose the build mode." FORCE)
endif()
set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS Debug Release MinSizeRel RelWithDebInfo Coverage) to default to ok, yes, this is wholly acceptable now. |
Beta Was this translation helpful? Give feedback.
-
|
oh yeah, much much much better. you might want to consider that snippet i posted above. i had been refraining from recommending contour due to the performance. this is much more competitive. |
Beta Was this translation helpful? Give feedback.
-
|
@dankamongmen btw, did you ever try notcurses (notcurses-info specifically) on osx? None of the TEs I tested do look as expected, not even close. Terminal.app being the shittiest amongst the gansters, but I start to question if that's an issue on the TE side or OSX/PTY-kernel side. not sure yet. wanna see screenshots? |
Beta Was this translation helpful? Give feedback.
-
|
@uspasojevic96 knows the most here. I am seeing this consistently because notcurses renders whitespace when wcstombs fails to convert, regardless of the terminal being used. Echo'ing out the Codepoints directly works as expected. |
Beta Was this translation helpful? Give feedback.
-
!!! |
Beta Was this translation helpful? Give feedback.
-
|
Dont ever use wcstombs. It is locale dependent. Terminals now-a-days all expect UTF-8. Encoding to UTF-8 is trivial, like a ten line function, feel free to use the one in charsets.c from the kitty source code. |
Beta Was this translation helpful? Give feedback.
-
|
i'm always in a UTF-8 or US-ASCII encoding (enforced in |
Beta Was this translation helpful? Give feedback.
-
|
Good you are getting rid of it, but to be more precise wcstombs() is global state dependent. Since not curses is a library embedded in applications, there is no way you can enforce any value for that global state. A thread running in the application could change the locale just before the thread you are calling wcstombs in runs. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @dankamongmen . I just git pull updated my local notcurses copy to run a fresh test and noticed you are having a TERMINALS.md. There however you mention that contour does NOT support Pixel |
Beta Was this translation helpful? Give feedback.
-
|
like an unloved product. |
Beta Was this translation helpful? Give feedback.
-
|
like a markdown that doesn't interact in any way with tests or day-to-day use. updated, thanks for the heads up! and to be honest, until i started building with |
Beta Was this translation helpful? Give feedback.
-
|
I absolutely agree, With regards to performance, there is a lot of improvement to come. I'm trying to finally push my grid branch through that is fundamentally rewriting the underlying grid, currently trying to slim it down and leave all the optimizations that i did NOT finish stabelizing yet for future PRs. I'll buzz you later then. With regards to usability (despite the tons of wishes I've already created tickets for), please just tell me. In the end I want to create a product that is "usable" - not just successfully compiling and used by me. :) |
Beta Was this translation helpful? Give feedback.
-
|
i have found it completely usable now that it's not agonizingly slow, aside from when it crashes rendering glyphs uttered in the dreams of ten thousand dead drunkards. i promoted it into my first rank of terminals to test with, at the cost of one other which shall go unnamed, but really does need give me graphic transparency. |
Beta Was this translation helpful? Give feedback.
-
|
and thanks i have updated several things in TERMINAL.md after a lookover |
Beta Was this translation helpful? Give feedback.
-
|
您好，您的邮件已收到，祝好！（熊任远）
|
Beta Was this translation helpful? Give feedback.
-
Hey @dankamongmen (why is autocompletion working for everyone but not for your name? so sad I am).
In my attempt to make notcurses as happy as it can get - simply by looking at the output of
notcurses-infofor the time being I realized that:3x2-is indicated as not available. hm, I agree, I just merged these to master.defbg 0x101010 not considered transparentHow do you decide that something is or is not transparent? Am I maybe not passing all the information to you so that you can find out?notcurses-infoon top next to the others and depending on that, also (if enabled) the emoji line would then look evenly spaced, too!. Sounds interesting?Okay, so much about just asking a simple question. Now this post looks like a status report spiced with a few questions. I hope I did not scare you or others away with that. ;)
Beta Was this translation helpful? Give feedback.
All reactions