Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Relative Import On Contribute Install #1244

Closed
3 tasks done
kivo360 opened this issue May 7, 2024 · 7 comments
Closed
3 tasks done

Invalid Relative Import On Contribute Install #1244

kivo360 opened this issue May 7, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@kivo360
Copy link

kivo360 commented May 7, 2024

Before submitting your bug report

Relevant environment info

- OS: macos 14.4.1
- Continue: 0.8.24
- IDE: vscode

Description

Invalid relative import when installing dev environment.

To reproduce

  1. Clone repo and cd to continue
  2. Run task: Install all dependencies
  3. When the extensions package builds I encounter an error.

Log output

Error: Command failed: npx vsce package --out ./build patch
 ERROR  invalid relative path: extension/../../core/node_modules/@mozilla/readability/.eslintrc.js

    at ChildProcess.exithandler (node:child_process:419:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket.<anonymous> (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28)
    at Pipe.<anonymous> (node:net:320:12) {
  code: 1,
  killed: false,
  signal: null,
  cmd: 'npx vsce package --out ./build patch'
}
@kivo360 kivo360 added the bug Something isn't working label May 7, 2024
@sestinj
Copy link
Contributor

sestinj commented May 8, 2024

@kivo360 This looks to be solved in the latest preview branch after I updated package-lock files. Can you confirm that it looks okay now?

@sestinj sestinj self-assigned this May 8, 2024
@wertyac
Copy link

wertyac commented May 9, 2024

hi, guys. I meet the same issue. I check out the preview branch. not solved.
Executing prepublish script 'npm run vscode:prepublish'...

continue@0.9.96 vscode:prepublish
npm run esbuild-base -- --minify

continue@0.9.96 esbuild-base
node esbuild.js --minify

This extension consists of 21827 files, out of which 12100 are JavaScript files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension . You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore
ERROR invalid relative path: extension/../../core/node_modules/@mozilla/readability/.eslintrc.js

@sestinj
Copy link
Contributor

sestinj commented May 9, 2024

@kivo360 @wertyac we just switched to using only yarn: b99fcbc

which I think should actually solve this problem. You're right that the previous was a false alarm—please let me know if this one also appears to be

Furthermore we had a contributor open this PR: #1255, which should resolve the files problem completely

@xiaoxia0617
Copy link

The solution for this issue should be:

  1. go to extensions/vscode folder
  2. change npm to yarn, execute "yarn install"
  3. then execute "npm link @continuedev/core"
  4. last execute "yarn package"
    Reason:
    The "vsce package" use yarn to pack defaultly, there is some incompatibality unknown, but once you change npm to yarn under "extensions/vscode" to do package, that issue will not show again.

@kivo360
Copy link
Author

kivo360 commented May 12, 2024

Trying it when I get back home

@kivo360
Copy link
Author

kivo360 commented May 15, 2024

The solution for this issue should be:

  1. go to extensions/vscode folder
  2. change npm to yarn, execute "yarn install"
  3. then execute "npm link @continuedev/core"
  4. last execute "yarn package"
    Reason:
    The "vsce package" use yarn to pack defaultly, there is some incompatibality unknown, but once you change npm to yarn under "extensions/vscode" to do package, that issue will not show again.

I was able to get past the relative issue. Now I'm stuck with trying to download the esbuild binary for Mac M1 processors.

My next issue is listed here: #1289

@kivo360
Copy link
Author

kivo360 commented May 15, 2024

Since I have a new problem to deal with, I'm closing this issue as complete.

@kivo360 kivo360 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants