Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Support traced placeholder for images #4

Closed
stefanjudis opened this issue Feb 20, 2018 · 2 comments
Closed

Support traced placeholder for images #4

stefanjudis opened this issue Feb 20, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@stefanjudis
Copy link
Contributor

Traced placeholders are a very nice way to improve the user experience for images that are still loading. It would be awesome to have these. 馃帀

traced
@stefanjudis stefanjudis added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 20, 2018
@axe312ger
Copy link
Contributor

axe312ger commented Feb 21, 2018 •
edited

I love this feature so much and would freak out to see it working with gatsby + contentful.

Issue here is: The tracing has to run on the local machine since contentfuls image api does not support this. We would need to patch the contentful source plugin to support that feature.

It would have to work somehow this way:

  1. Download image from Contentful image API to the local machine
  2. Run the trace from gatsby-plugin-sharp on these images
  3. Extend the query fragments to contain these new traced images as base64

馃殌 馃帀

@stefanjudis stefanjudis removed the good first issue Good for newcomers label Feb 22, 2018
@axe312ger axe312ger mentioned this issue Feb 23, 2018
Closed
@axe312ger
Copy link
Contributor

Fixed in #26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Traced/primitive svg previews contentful-userland/gatsby-contentful-starter
2 participants
@stefanjudis @axe312ger