Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links of links don't resolve properly #12

Open
stavro opened this issue Oct 11, 2017 · 2 comments
Open

Links of links don't resolve properly #12

stavro opened this issue Oct 11, 2017 · 2 comments

Comments

@stavro
Copy link

stavro commented Oct 11, 2017

I have a blog post -> author -> image relationship. When requesting the blog post, both the author and images show up in the includes field in the resposne, but the resolve logic in this library doesn't flatten it out properly, and then image source is lost.

VCR'd Fixture: https://gist.github.com/stavro/fb38c303017549feb07e51f4b7665eb0

Expected: Be able to access the author's image.

Actual: Image is not available after this library parses the response. It is in the response though.

ramonsnir added a commit to ramonsnir/contentful.ex that referenced this issue Oct 13, 2017
@WillRochaThomas
Copy link

@floriank should this issue be closed? I noticed the associated PR was, because this issue was based on old code?

@WillRochaThomas
Copy link

I think my PR will fix this for all types of links going forward #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants