Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Notification on completion #95

Open
MadsBen opened this issue Feb 6, 2023 · 5 comments · May be fixed by #120
Open

Request: Notification on completion #95

MadsBen opened this issue Feb 6, 2023 · 5 comments · May be fixed by #120

Comments

@MadsBen
Copy link

MadsBen commented Feb 6, 2023

Hello

I have a small feature request. Today you only get a notification if a service has been updated or it has failed to update.
But sometimes Shepherd can run a few days, without having updates to services. But you receive no notifications, so you don't know if Shepherd has run successfully and complete the check or whether it has failed.

So the request is: A notification on a completed run.

@shizunge

This comment was marked as spam.

@maveice
Copy link

maveice commented Nov 19, 2023

Yes, absolutely - I do support this. A notification functions such as mail would be very helpful.

@martadinata666
Copy link

Shouldn't this working? https://github.com/containrrr/shepherd/blob/master/examples/docker-compose.apprise.yml as shepherd essentially a bash script, it just passing anything to apprise container that will send notification for you

shepherd/shepherd

Lines 97 to 100 in 01d070a

if [[ "$apprise_sidecar_url" != "" ]]; then
title="[Shepherd] Error updating service $name"
body="$(date) Service $name Image $image does not exist or it is not available"
curl -X POST -H "Content-Type: application/json" --data "{\"title\": \"$title\", \"body\": \"$body\", \"type\": \"failure\"}" "$apprise_sidecar_url"

@maveice
Copy link

maveice commented Nov 19, 2023

@martadinata666 Yes, I see. However, as I am not a programmer or expert I was looking for some easy parameters such as smtp-server, port, tls etc. as we find it in other apps, too.

Any other alternative that provides an easier solution is very much appreciated.

@martadinata666
Copy link

well technically you just need update the notification url at apprise container sample above. Look at https://github.com/caronc/apprise for reference

moschlar added a commit that referenced this issue Nov 20, 2023
Uses apprise sidecar url, if configured, to send an "info" notification
after each run of the update_services loop.

Closes: #95
@moschlar moschlar linked a pull request Nov 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants