Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image cleanup will occurs only on node running the shepherd container #84

Open
mulder999 opened this issue Nov 30, 2022 · 5 comments
Open
Labels

Comments

@mulder999
Copy link

mulder999 commented Nov 30, 2022

Actual:
Actual implementation do the image cleanup only on the node running the shepherd container, not on the node running the service updated, nor on any other

Expected:
In decreasing preference order:

  • Cleanup on every nodes, keeping the image digest matching the updated image (rem: image digest is immutable not the image ID)
  • Cleanup on every nodes
  • Cleanup on node running the service
  • Limitation highlighted in documentation
@djmaze
Copy link
Collaborator

djmaze commented Jan 18, 2023

Sorry for the late answer. Personally I think the integrated image cleanup was the wrong way to go. I propose to run docker system prune regularly on every docker node. That should solve all the problems. What do you think?

@djmaze djmaze added the bug label Jan 18, 2023
@mulder999
Copy link
Author

Hi thanks for reply. Yes this could do. Assuming this would force to have an agent on each cluster node as done by portainer. This local agent could then also help taking decision for smarter update trigger.

@djmaze
Copy link
Collaborator

djmaze commented Jan 20, 2023

Agent.. Well.. Or keep it easy and add it as a cron job. (Unfortunately, swarm-cronjob does not reliably run global mode services, otherwise I would recommend that.)

@mulder999
Copy link
Author

Cron could actually replace shepered everywhere.

In fact, I was hoping to eventually replace my cron jobs by shepered but as is it provides too little value for me yet.

@shizunge

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants