Remove unnecessary chdir #2780
Remove unnecessary chdir #2780
Conversation
|
I've checked the relevant tests that came from containerd were passed. |
| @@ -44,8 +44,7 @@ Vagrant.configure("2") do |config| | |||
| ./script/setup/install-cni | |||
| ./script/setup/install-critools | |||
| rm -rf /bin/runc /sbin/runc /usr/sbin/runc /usr/bin/runc | |||
|
|
|||
| cp /vagrant/youki/youki /usr/bin/runc | |||
| ln -s /vagrant/youki/youki /usr/bin/runc | |||
There was a problem hiding this comment.
It'd be more beneficial because we don't need to copy again when we rebuild.
|
I'll check CI. |
Co-authored-by: jiaxiao zhou <jiazho@microsoft.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com> Signed-off-by: utam0k <k0ma@utam0k.jp>
|
@Furisto Can you take a look at this PR? |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
|
@Mossaka can you confirm that this branch's youki build resolved the original perf issues you were facing? So that once this PR is checked from the our side, we can merge and make a release. |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Just confirmed, it solved the original perf issue we are facing |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
| use std::{fs, io::Write, os::unix::prelude::RawFd, path::PathBuf, rc::Rc}; | ||
|
|
||
| use libcgroups::common::CgroupManager; | ||
| use nix::unistd::Pid; | ||
| use oci_spec::runtime::Spec; | ||
|
|
There was a problem hiding this comment.
thought: We should have a rustfmt.toml to standardize this.
I personally like the one that @Mossaka put together for runwasi.
https://github.com/containerd/runwasi/blob/main/rustfmt.toml
There was a problem hiding this comment.
I didn't know that. It is what I want! Thanks for sharing.
Signed-off-by: utam0k <k0ma@utam0k.jp>
Fix: #2772
These
chdirare unexpected forlibcontainer's users.