Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling and pass error to the parent process and/or caller of libcontainer #2389

Open
yihuaf opened this issue Sep 26, 2023 · 5 comments
Labels
help wanted Extra attention is needed kind/feature

Comments

@yihuaf
Copy link
Collaborator

yihuaf commented Sep 26, 2023

If the init process errors, we currently close the channel and exit. The only context around the error are in the logs/traces. This is not good UX for libcontainer interface. A better design is to return error through the channel back to the parent process so the parent process can log it and/or return to the caller.

@yihuaf yihuaf added help wanted Extra attention is needed kind/feature labels Sep 26, 2023
@jsturtevant
Copy link

Example where this error message was confusing: containerd/runwasi#326. There were other issues in the way we consumed the api's but I was expecting the error returned to be an error based on the validation code, i.e was expecting module not found not failed to receive. \"waiting for init ready\",

@utam0k
Copy link
Member

utam0k commented Sep 28, 2023

👍

@utam0k
Copy link
Member

utam0k commented Sep 28, 2023

This is one of the most important features for us. It may seem surprising, but it will probably be a unique feature not found in any runtime.

@peter-jerry-ye
Copy link

May I ask if there's any workaround for now to get the error message?

@utam0k
Copy link
Member

utam0k commented Dec 10, 2023

@peter-jerry-ye You can get the error message with bpftrace.
https://containers.github.io/youki/developer/debugging.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

4 participants