feat: file input #7238
Merged
feat: file input #7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes containers#7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
axel7083
and removed request for
a team
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes containers#7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
May 17, 2024
lstocchi
reviewed
May 22, 2024
cdrage
approved these changes
May 22, 2024
@lstocchi that is unrelated and unfortunately affects all configuration even prior to this. I opened #7142 to track it and you can see it affect other settings. |
|
Is it possible to clear a value once you have already chosen a directory/file? I cannot find a way to do this before/after this PR, but as we are creating a specific component, it would be interesting to support this possibility to reset a value to /undefined/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for.
Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it.
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
Fixes #7197.
How to test this PR?
Tests added, check Settings > Preferences for usability/regression.