-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileInput component #7197
Labels
Comments
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
May 16, 2024
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes containers#7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
May 17, 2024
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes containers#7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
May 22, 2024
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes #7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
that referenced
this issue
May 22, 2024
We have Inputs next to Browse buttons in many places, all with slight variations in UI or browsing. This creates a new FileInput component that uses a regular Input component with a folder icon on the right to browse for files. Exposes OpenDialogOptions to make it easy to customize what the file dialog should filter for. Uses the new FileInput for file/folder preferences so that there's something to test. There are several other file/browse buttons elsewhere, but they would be migrated separately. Likely also a candidate for svelte-ui package, but that should be after we become comfortable with/use it. Fixes #7197. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
Florent made a good observation in a PR review or issue a while ago that I can't find at the moment, but we have a number of places where we have an Input followed by a Browse button, and in some cases they are slightly different UI or copy/paste code.
Describe the solution you'd like
We should reduce tech debt and have a common FileInput component.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: