Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send two times a question on chatbot recipe app without waiting the previous answer is crashing the app #497

Closed
benoitf opened this issue May 13, 2024 · 1 comment · Fixed by #498
Closed

Send two times a question on chatbot recipe app without waiting the previous answer is crashing the app #497

benoitf opened this issue May 13, 2024 · 1 comment · Fixed by #498
Assignees
@jeffmaury

Comments

@benoitf
Copy link
Contributor

benoitf commented May 13, 2024

Bug description

I notice that during tons of sequences, if I send a new question before waiting the first answer to be completed, it crashed the application

Operating system

macOS 14.4

Installation Method

from ghcr.io/containers/podman-desktop-extension-ai-lab container image

Version

next (development version)

Steps to reproduce

v1.1.1

Screen.Recording.2024-05-13.at.14.20.02.mov

Relevant log output

No response

Additional context

No response
@benoitf benoitf mentioned this issue May 14, 2024
Open
@jeffmaury jeffmaury self-assigned this May 15, 2024
@MichaelClifford
Copy link
Collaborator

I looked into this a bit. I will submit a PR that adds the --interrupt_requests False as the default value which should help, but will not fully solve this problem. A proper fix I think would be to disable the chat_input box during generation. However, this seems to not be implemented in streamlit currently.

@MichaelClifford MichaelClifford mentioned this issue May 15, 2024
Merged
@jeffmaury jeffmaury transferred this issue from containers/podman-desktop-extension-ai-lab May 17, 2024
jeffmaury added a commit to jeffmaury/ai-lab-recipes that referenced this issue May 17, 2024
@jeffmaury
fix: prevent multipes requests in chatbot recipe
3506991 
Fixes containers#497

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jeffmaury added a commit to jeffmaury/ai-lab-recipes that referenced this issue May 17, 2024
@jeffmaury
fix: prevent multipes requests in chatbot recipe
1ba69fc 
Fixes containers#497

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury mentioned this issue May 17, 2024
Merged
MichaelClifford pushed a commit that referenced this issue May 17, 2024
@jeffmaury
fix: prevent multipes requests in chatbot recipe (#498)
d25371d 
Fixes #497

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffmaury jeffmaury

Labels
None yet
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent multipes requests in chatbot recipe jeffmaury/ai-lab-recipes
3 participants
@benoitf @jeffmaury @MichaelClifford