Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check resources on Linux #1088

Merged
merged 2 commits into from
May 16, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 14, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes #1022

How to test this PR?

On Linux, Go to a Recipe page and check that no warning about podman machine is displayed

@feloy feloy requested review from benoitf and a team as code owners May 14, 2024 15:15
@feloy feloy requested a review from jeffmaury May 14, 2024 15:15
@feloy feloy changed the title Bugfix 1022/no resource check on linux Do not check resources on Linux May 14, 2024
@feloy feloy requested a review from lstocchi May 14, 2024 15:15
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the bugfix-1022/no-resource-check-on-linux branch from 412e675 to 2e23718 Compare May 14, 2024 15:16
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the bugfix-1022/no-resource-check-on-linux branch from 2e23718 to eda8ea8 Compare May 14, 2024 15:23
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM and thanks for fixing it!!

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feloy feloy merged commit 22928e0 into containers:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Podman machine running banner should not be displayed on Linux
3 participants