Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerd breaking change in main branch #475

Open
Mossaka opened this issue Feb 6, 2024 · 3 comments
Open

Containerd breaking change in main branch #475

Mossaka opened this issue Feb 6, 2024 · 3 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Feb 6, 2024

currently on the main branch containerd only issues shim delete for the sandbox during sandbox cleanup.

ref: containerd/containerd#9727

@squillace
Copy link

thanks a ton for looking into this, @Mossaka

@Mossaka
Copy link
Member Author

Mossaka commented Feb 7, 2024

I ran all our tests against the main branch containerd and all passed.

@jsturtevant
Copy link
Contributor

from the issue it looks like we just need to avoid mixing shim versions containerd/containerd#9727 (comment)

So, it looks unsafe to use current podsandbox mode to integrate with old version shim. That's why I say that we should update shim doc and highlight it changelog.

I tried to add a nightly job using kind but it didn't work since Kind currently fails to load images since it can't parse the new containerd config version 3 yet.

https://github.com/containerd/runwasi/compare/main...jsturtevant:runwasi:add-nightly-contianerd-job?expand=1

If fails with ERROR: failed to detect containerd snapshotter since kind image loader parses the wrong config layout: https://github.com/kubernetes-sigs/kind/blob/c83316d25e1c40f1c66982b637edf3ee34a5e0d4/pkg/cluster/nodeutils/util.go#L105-L108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants