feat(wamr): add wasm-mico-runtime shim implementation #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds an additional shim implementation: Wamr using wamr-rust-sdk Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Mossaka
commented
Mar 7, 2024
| @@ -3,7 +3,7 @@ INSTALL ?= install | |||
| CARGO ?= cargo | |||
| LN ?= ln -sf | |||
| TEST_IMG_NAME ?= wasmtest:latest | |||
| RUNTIMES ?= wasmedge wasmtime wasmer | |||
| RUNTIMES ?= wasmedge wasmtime wasmer wamr | |||
|
this is GREAT! |
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
lum1n0us
reviewed
Mar 8, 2024
| let instance = WamrInstnace::new(&module, 1024 * 64) | ||
| .map_err(|e| anyhow::Error::msg(format!("Failed to create instance: {:?}", e)))?; | ||
|
|
||
| // TODO: bug: failed at line above saying: `thread signal env initialized failed` |
There was a problem hiding this comment.
I am thinking about Self { runtime } may has been destroyed. It happened several times in my test cases when implementing rust-sdk. Is there a quick way we can confirm that?
There was a problem hiding this comment.
yeah i believe that when the variable let runtime = Runtime::new() goes out of scope, the Drop() will be invoked to destruct it.
There was a problem hiding this comment.
Let's probably why I favor the design of a binding the runtime to the variable and pass that to instances like wasmtime does.
let engine = Engine::default();
let module = Module::new(&engine, wat)?;
let mut store = Store::new(&engine, 4);There was a problem hiding this comment.
about that, bytecodealliance/wamr-rust-sdk#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds an additional shim implementation: Wamr using wamr-rust-sdk. At the moment, the shim isn't working with an error
"thread signal env initialized failed"which I am not sure exactly sure what it means. Will ask the Wamr team for clarification. There are also some pain points using the newly created wamr-rust-sdk which I wrote as TODOs in the comment.This PR should close #337
FYI @squillace @0xE282B0 @lum1n0us