Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug comments are not linked to the original text after edit #5529

Open
Avi-ADAM opened this issue May 3, 2024 · 1 comment
Open

bug comments are not linked to the original text after edit #5529

Avi-ADAM opened this issue May 3, 2024 · 1 comment

Comments

@Avi-ADAM
Copy link

Avi-ADAM commented May 3, 2024

User Story

when looking at a proposal the comments are linked to the text via yellow marks , but after the text get edited the yellow marks and the comments are in different location from where they originally assigned

Why is this Needed?

allow editing proposals while keep the comments linked to text

Type: Bug

Steps to reproduce

add comment to proposal then edit the proposal and add some text before the commented text, you will see that now the comment not linked to the original text

Definition of Done

comments linked to text not word counter

@javierm
Copy link
Member

javierm commented May 6, 2024

Hi, @Avi-ADAM 😄.

If we're talking about comments on legislation drafts, this actually works as intended, although I agree that it's confusing.

The idea is that, once a draft version is published and people add comments to it, you no longer edit it (maybe we should add a validation rule for this 🤔) but create a new draft version instead.

I don't think it's possible to change the current behavior at least until we replace the library we use to add annotations (which is no longer maintained).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants