Investment admin opens in new window

[coslajohn]

Why is this Needed?

1. When reviewing and valuating investments from /admin/budgets/1/budget_investments clicking on an investment opens a new window. This means that you can quickly end up with many windows open. Clicking the back link when complete, goes back in the new window, leaving the original window orphaned
   

Expected Behaviour

comment: # It would seem to make more sense to open in the same window

[javierm]

Hi, @coslajohn 😄.

We've recently changed most the "opens in new window" links (see pull request #5282), but we've kept that one because changing it introduces (in my humble opinion) a bigger usability issue.

The way many people manage investments is to filter them, edit one, and then expect the index page to keep the filters. Unfortunately that isn't the case, so we open investments in a new window as a compromise solution, so people have a way to go back to the index page with the filters applied.

I'm keeping the issue open because, as you point out, there is a usability issue here (thanks for reporting, by the way!). Maybe a way to solve it could be to store the filters in the session so administrators don't lose them after editing an investment (or, at least, that's a practice I've seen and done in past projects) 🤔.

[coslajohn]

@javierm very few of our users seem to use the filters. They just want to click on an investment, do the edit, and then go back to the list. It becomes even more of a problem if you try to do it on a tablet.

Your suggestion of keeping the filter state in the session would seem to keep us both happy 😄

[javierm]

It becomes even more of a problem if you try to do it on a tablet.

Glad to see administrators using a tablet. We could definitely improve the experience in the admin section for people using these sceens.