It is possible to modify from a knapsack budget to an approval budget and vice-versa

[microweb10]

Description

We found out that, even the budget is already in the voting phase, and even it has received votes:

• Changing a budget from a knapsack budget to an approval budget and vice-versa is possible.
• Changing the number of investments you can vote on to an approval budget is possible.

Why is this Needed?

When this is not going to raise any error, the result of the voting can be altered, so users can vote more times than they should. 😅

What can be done about it?

There are some different solutions to this problem:

• Allow admins to set those parameters only on creation. Not being able to modify them after the budget is created.
• Do not allow admins to modify those parameters when the phase is voting or later.
• Do not allow admins to modify those parameters if there are already votes for that budget.

And of course, there may be more solutions. ☺️
If the Consul Democracy has any specific preference about this, please let us know.
I might be able to work on a fix. 😉

Example 1 (screenshot)

A user voted more times than should.

Example 2 (screenshot)

A user spent more money than should.