OneOf validator fails when given a set of byte characters

[nan-af]

In [2]: from construct import *

In [3]: criteria = OneOf(Byte, {b'h', b'i'})

In [4]: criteria.parse(b'h')
ValidationError: Error in path (parsing)
object failed validation: 104


In [5]: criteria.parse(b'i')
ValidationError: Error in path (parsing)
object failed validation: 105


In [6]: criteria = OneOf(Byte, {ord('h'), ord('i')})

In [7]: criteria.parse(b'h')
Out[7]: 104

In [8]: criteria.parse(b'i')
Out[8]: 105

I believe we should get identical behaviour for b'h' and ord('h'). I have observed this behaviour when running construct 2.10.68 on python 3.10.12.

[franzhaas]

I think this is correct

https://construct.readthedocs.io/en/latest/advanced.html

Byte is a 8bit integer, not a single element byte array.

What you are looking for is probably Bytes(1)

from construct import *
criteria = OneOf(Bytes(1), {b'h', b'i'})
criteria.parse(b'h')

[nan-af]

🤔
It's confusing but okay

[franzhaas]

Took me a while to get used to as well... but actually it is a beautiful solution, as all arrays (1-N elements) behave similarly, and all scalars do, there is no "Schroedingers" datatype which might be a single element array or a scalar.

If that's ok for you would you mind to close the ticket?

[nan-af]

Hello, my apologies for the delay.

I was actually hoping to see what the author has to say about it :)

[arekbulski]

I am too confused to give you a meaningful response.